From: Tarek Ziade Date: Mon, 30 May 2011 10:25:38 +0000 (+0200) Subject: displaying the faulty project name is a good idea X-Git-Tag: v3.3.0a1~2183^2~21^2~6 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b9c09878ab8390aa9b78ff468f42ed91bae2b1fe;p=python displaying the faulty project name is a good idea --- diff --git a/Lib/packaging/metadata.py b/Lib/packaging/metadata.py index 596eec796a..53d91f7451 100644 --- a/Lib/packaging/metadata.py +++ b/Lib/packaging/metadata.py @@ -396,22 +396,24 @@ class Metadata: value = [] if logger.isEnabledFor(logging.WARNING): + project_name = self['Name'] + if name in _PREDICATE_FIELDS and value is not None: for v in value: # check that the values are valid predicates if not is_valid_predicate(v.split(';')[0]): logger.warning( - '%r is not a valid predicate (field %r)', - v, name) + '%r: %r is not a valid predicate (field %r)', + project_name, v, name) # FIXME this rejects UNKNOWN, is that right? elif name in _VERSIONS_FIELDS and value is not None: if not is_valid_versions(value): - logger.warning('%r is not a valid version (field %r)', - value, name) + logger.warning('%r: %r is not a valid version (field %r)', + project_name, value, name) elif name in _VERSION_FIELDS and value is not None: if not is_valid_version(value): - logger.warning('%r is not a valid version (field %r)', - value, name) + logger.warning('%r: %r is not a valid version (field %r)', + project_name, value, name) if name in _UNICODEFIELDS: if name == 'Description':