From: Victor Stinner <victor.stinner@haypocalc.com>
Date: Fri, 30 Apr 2010 16:37:52 +0000 (+0000)
Subject: PyUnicode_DecodeFSDefaultAndSize() uses surrogateescape error handler
X-Git-Tag: v3.2a1~962
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b9a20ad036ea0e4b8dd2f57158375d5138dd0663;p=python

PyUnicode_DecodeFSDefaultAndSize() uses surrogateescape error handler

This function is only used to decode Python module filenames, but Python
doesn't support surrogates in modules filenames yet. So nobody noticed this
minor bug.
---

diff --git a/Misc/NEWS b/Misc/NEWS
index e1b011608e..b7e93182af 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -12,6 +12,8 @@ What's New in Python 3.2 Alpha 1?
 Core and Builtins
 -----------------
 
+- PyUnicode_DecodeFSDefaultAndSize() uses surrogateescape error handler
+
 - Issue #8419: Prevent the dict constructor from accepting non-string keyword
   arguments.
 
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
index 369306e368..23b322f304 100644
--- a/Objects/unicodeobject.c
+++ b/Objects/unicodeobject.c
@@ -1600,19 +1600,19 @@ PyUnicode_DecodeFSDefaultAndSize(const char *s, Py_ssize_t size)
     if (Py_FileSystemDefaultEncoding) {
 #if defined(MS_WINDOWS) && defined(HAVE_USABLE_WCHAR_T)
         if (strcmp(Py_FileSystemDefaultEncoding, "mbcs") == 0) {
-            return PyUnicode_DecodeMBCS(s, size, "replace");
+            return PyUnicode_DecodeMBCS(s, size, "surrogateescape");
         }
 #elif defined(__APPLE__)
         if (strcmp(Py_FileSystemDefaultEncoding, "utf-8") == 0) {
-            return PyUnicode_DecodeUTF8(s, size, "replace");
+            return PyUnicode_DecodeUTF8(s, size, "surrogateescape");
         }
 #endif
         return PyUnicode_Decode(s, size,
                                 Py_FileSystemDefaultEncoding,
-                                "replace");
+                                "surrogateescape");
     }
     else {
-        return PyUnicode_DecodeUTF8(s, size, "replace");
+        return PyUnicode_DecodeUTF8(s, size, "surrogateescape");
     }
 }