From: Gregory P. Smith <greg@krypto.org>
Date: Fri, 1 Feb 2013 21:03:39 +0000 (-0800)
Subject: Additional fix for Issue #12268: The io module file object writelines() methods no... 
X-Git-Tag: v3.3.1rc1~256^2~1^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b9817b01edfe6fa369c4c291a5de00732b8abc7c;p=python

Additional fix for Issue #12268: The io module file object writelines() methods no longer abort early when one of its write system calls is interrupted (EINTR).
---

diff --git a/Misc/NEWS b/Misc/NEWS
index 917ab8d062..4431f1878c 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -817,6 +817,9 @@ Library
 Extension Modules
 -----------------
 
+- Issue #12268: The io module file object writelines() methods no longer
+  abort early when one of its write system calls is interrupted (EINTR).
+
 - Fix the leak of a dict in the time module when used in an embedded
   interpreter that is repeatedly initialized and shutdown and reinitialized.
 
diff --git a/Modules/_io/iobase.c b/Modules/_io/iobase.c
index ba86146790..8b17ecdd85 100644
--- a/Modules/_io/iobase.c
+++ b/Modules/_io/iobase.c
@@ -674,7 +674,10 @@ iobase_writelines(PyObject *self, PyObject *args)
                 break; /* Stop Iteration */
         }
 
-        res = PyObject_CallMethodObjArgs(self, _PyIO_str_write, line, NULL);
+        res = NULL;
+        do {
+            res = PyObject_CallMethodObjArgs(self, _PyIO_str_write, line, NULL);
+        } while (res == NULL && _PyIO_trap_eintr());
         Py_DECREF(line);
         if (res == NULL) {
             Py_DECREF(iter);
diff --git a/Modules/_io/textio.c b/Modules/_io/textio.c
index 2fbb8f3052..7d48388493 100644
--- a/Modules/_io/textio.c
+++ b/Modules/_io/textio.c
@@ -1249,8 +1249,11 @@ _textiowrapper_writeflush(textio *self)
     Py_DECREF(pending);
     if (b == NULL)
         return -1;
-    ret = PyObject_CallMethodObjArgs(self->buffer,
-                                     _PyIO_str_write, b, NULL);
+    ret = NULL;
+    do {
+        ret = PyObject_CallMethodObjArgs(self->buffer,
+                                         _PyIO_str_write, b, NULL);
+    } while (ret == NULL && _PyIO_trap_eintr());
     Py_DECREF(b);
     if (ret == NULL)
         return -1;