From: Mark Dickinson <mdickinson@enthought.com>
Date: Sat, 19 Nov 2011 17:58:15 +0000 (+0000)
Subject: Issue #9530: Fix undefined behaviour due to signed overflow in testcapi_long.h.
X-Git-Tag: v3.3.0a1~806
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b96172e2cfbbd047959cb8b2a5b84b0b32388842;p=python

Issue #9530: Fix undefined behaviour due to signed overflow in testcapi_long.h.
---

diff --git a/Modules/testcapi_long.h b/Modules/testcapi_long.h
index 5784452edf..6bddad7bb5 100644
--- a/Modules/testcapi_long.h
+++ b/Modules/testcapi_long.h
@@ -33,8 +33,7 @@ TESTNAME(PyObject *error(const char*))
             unsigned TYPENAME uin, uout;
 
             /* For 0, 1, 2 use base; for 3, 4, 5 use -base */
-            uin = j < 3 ? base
-                        : (unsigned TYPENAME)(-(TYPENAME)base);
+            uin = j < 3 ? base : 0U - base;
 
             /* For 0 & 3, subtract 1.
              * For 1 & 4, leave alone.