From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Thu, 18 Aug 2011 13:47:31 +0000 (+0300)
Subject: Report libpq errors correctly if session setup or teardown steps fail in
X-Git-Tag: REL9_1_RC1~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b936d9264c08418909e3ec5d6107bd104d62fdc2;p=postgresql

Report libpq errors correctly if session setup or teardown steps fail in
isolation regression tests.

Alvaro committed these fixes to master branch on Tue Jul 29th, as part of
Noah Misch's patch. The rest of that patch is not needed on 9.1, but this
part should be backpatched.
---

diff --git a/src/test/isolation/isolationtester.c b/src/test/isolation/isolationtester.c
index 65a8fd2614..1d76f2cd08 100644
--- a/src/test/isolation/isolationtester.c
+++ b/src/test/isolation/isolationtester.c
@@ -286,7 +286,7 @@ run_permutation(TestSpec * testspec, int nsteps, Step ** steps)
 			{
 				fprintf(stderr, "setup of session %s failed: %s",
 						testspec->sessions[i]->name,
-						PQerrorMessage(conns[0]));
+						PQerrorMessage(conns[i]));
 				exit_nicely();
 			}
 			PQclear(res);
@@ -333,7 +333,7 @@ run_permutation(TestSpec * testspec, int nsteps, Step ** steps)
 			{
 				fprintf(stderr, "teardown of session %s failed: %s",
 						testspec->sessions[i]->name,
-						PQerrorMessage(conns[0]));
+						PQerrorMessage(conns[i]));
 				/* don't exit on teardown failure */
 			}
 			PQclear(res);