From: Serhiy Storchaka <storchaka@gmail.com>
Date: Sun, 11 Mar 2018 06:38:13 +0000 (+0200)
Subject: bpo-32338: OrderedDict import is no longer needed in re. (#4891)
X-Git-Tag: v3.8.0a1~2101
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b931bd0a2fe7e9293339019352baf3317166b769;p=python

bpo-32338: OrderedDict import is no longer needed in re. (#4891)
---

diff --git a/Lib/re.py b/Lib/re.py
index a8b6753d39..94d486579e 100644
--- a/Lib/re.py
+++ b/Lib/re.py
@@ -128,12 +128,6 @@ try:
 except ImportError:
     _locale = None
 
-# try _collections first to reduce startup cost
-try:
-    from _collections import OrderedDict
-except ImportError:
-    from collections import OrderedDict
-
 
 # public symbols
 __all__ = [
@@ -271,7 +265,7 @@ Match = type(sre_compile.compile('', 0).match(''))
 # --------------------------------------------------------------------
 # internals
 
-_cache = OrderedDict()
+_cache = {}  # ordered!
 
 _MAXCACHE = 512
 def _compile(pattern, flags):
@@ -292,9 +286,10 @@ def _compile(pattern, flags):
     p = sre_compile.compile(pattern, flags)
     if not (flags & DEBUG):
         if len(_cache) >= _MAXCACHE:
+            # Drop the oldest item
             try:
-                _cache.popitem(last=False)
-            except KeyError:
+                del _cache[next(iter(_cache))]
+            except (StopIteration, RuntimeError, KeyError):
                 pass
         _cache[type(pattern), pattern, flags] = p
     return p