From: James Zern <jzern@google.com>
Date: Wed, 5 Mar 2014 03:46:29 +0000 (-0800)
Subject: msvs: filter out include-only asm files
X-Git-Tag: v1.4.0~2162^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b92f7bc960881ba340e949ce808f8275ad277343;p=libvpx

msvs: filter out include-only asm files

avoid building x86inc.asm, x86_abi_support.asm and vpx_config.asm as
they provide no symbols themselves

fixes:
 warning LNK4221: This object file does not define any previously
undefined public symbols, so it will not be used by any link operation
that consumes this library

Change-Id: Iecfe03aa76efbfc07c2af5b91ba5405634e45f1d
---

diff --git a/libs.mk b/libs.mk
index 302d2afbd..b6f641371 100644
--- a/libs.mk
+++ b/libs.mk
@@ -236,6 +236,13 @@ vpx.def: $(call enabled,CODEC_EXPORTS)
             --out=$@ $^
 CLEAN-OBJS += vpx.def
 
+# Assembly files that are included, but don't define symbols themselves.
+# Filtered out to avoid Visual Studio build warnings.
+ASM_INCLUDES := \
+    third_party/x86inc/x86inc.asm \
+    vpx_config.asm \
+    vpx_ports/x86_abi_support.asm \
+
 vpx.$(VCPROJ_SFX): $(CODEC_SRCS) vpx.def obj_int_extract.$(VCPROJ_SFX)
 	@echo "    [CREATE] $@"
 	$(qexec)$(GEN_VCPROJ) \
@@ -246,7 +253,8 @@ vpx.$(VCPROJ_SFX): $(CODEC_SRCS) vpx.def obj_int_extract.$(VCPROJ_SFX)
             --proj-guid=DCE19DAF-69AC-46DB-B14A-39F0FAA5DB74 \
             --module-def=vpx.def \
             --ver=$(CONFIG_VS_VERSION) \
-            --out=$@ $(CFLAGS) $^ \
+            --out=$@ $(CFLAGS) \
+            $(filter-out $(addprefix %, $(ASM_INCLUDES)), $^) \
             --src-path-bare="$(SRC_PATH_BARE)" \
 
 PROJECTS-$(BUILD_LIBVPX) += vpx.$(VCPROJ_SFX)