From: Jim Jagielski <jim@apache.org>
Date: Thu, 14 Feb 2008 13:37:18 +0000 (+0000)
Subject: Note why we aren't bothering to check that we have
X-Git-Tag: 2.3.0~966
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b8f5af8cbe0f5d83937f036daa9a0c79444e4643;p=apache

Note why we aren't bothering to check that we have
a valid octet here.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@627740 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/proxy/proxy_util.c b/modules/proxy/proxy_util.c
index 0a27b18c27..607ca98169 100644
--- a/modules/proxy/proxy_util.c
+++ b/modules/proxy/proxy_util.c
@@ -677,6 +677,9 @@ static int proxy_match_ipaddr(struct dirconn_entry *This, request_rec *r)
 
     if (4 == sscanf(host, "%d.%d.%d.%d", &ip_addr[0], &ip_addr[1], &ip_addr[2], &ip_addr[3])) {
         for (addr.s_addr = 0, i = 0; i < 4; ++i) {
+            /* ap_proxy_is_ipaddr() already confirmed that we have
+             * a valid octet in ip_addr[i]
+             */
             addr.s_addr |= htonl(ip_addr[i] << (24 - 8 * i));
         }