From: Nikita Popov Date: Mon, 3 Aug 2020 09:58:28 +0000 (+0200) Subject: Don't suppress notices in rfc1867 tests X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b891adea8d41c1d81696b69f4ae6c5266da730b2;p=php Don't suppress notices in rfc1867 tests The references notices in debug builds don't seem to be present anymore. --- diff --git a/ext/session/tests/rfc1867.phpt b/ext/session/tests/rfc1867.phpt index 21a70c8a28..0e189b7aa6 100644 --- a/ext/session/tests/rfc1867.phpt +++ b/ext/session/tests/rfc1867.phpt @@ -2,8 +2,6 @@ session rfc1867 --INI-- file_uploads=1 -error_reporting=E_ALL&~E_NOTICE -comment=debug builds show some additional E_NOTICE errors upload_max_filesize=1024 session.save_path= session.name=PHPSESSID diff --git a/ext/session/tests/rfc1867_cleanup.phpt b/ext/session/tests/rfc1867_cleanup.phpt index 63b4e4bc0d..ae5dcbe8dc 100644 --- a/ext/session/tests/rfc1867_cleanup.phpt +++ b/ext/session/tests/rfc1867_cleanup.phpt @@ -2,8 +2,6 @@ session rfc1867 --INI-- file_uploads=1 -error_reporting=E_ALL&~E_NOTICE -comment=debug builds show some additional E_NOTICE errors upload_max_filesize=1024 session.save_path= session.name=PHPSESSID @@ -48,7 +46,7 @@ session_start(); var_dump(session_id()); var_dump(basename(__FILE__) == $_POST[ini_get("session.upload_progress.name")]); var_dump($_FILES); -var_dump($_SESSION["upload_progress_" . basename(__FILE__)]); +var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)])); session_destroy(); ?> --EXPECTF-- @@ -82,4 +80,4 @@ array(2) { int(1) } } -NULL +bool(false) diff --git a/ext/session/tests/rfc1867_disabled.phpt b/ext/session/tests/rfc1867_disabled.phpt index 55707f6907..5bedb1de88 100644 --- a/ext/session/tests/rfc1867_disabled.phpt +++ b/ext/session/tests/rfc1867_disabled.phpt @@ -2,8 +2,6 @@ session rfc1867 disabled --INI-- file_uploads=1 -error_reporting=E_ALL&~E_NOTICE -comment=debug builds show some additional E_NOTICE errors upload_max_filesize=1024 session.save_path= session.name=PHPSESSID @@ -42,7 +40,7 @@ Content-Disposition: form-data; name="file2"; filename="file2.txt" session_start(); var_dump(session_id()); var_dump($_FILES); -var_dump($_SESSION["upload_progress_" . basename(__FILE__)]); +var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)])); session_destroy(); ?> --EXPECTF-- @@ -75,4 +73,4 @@ array(2) { int(1) } } -NULL +bool(false) diff --git a/ext/session/tests/rfc1867_disabled_2.phpt b/ext/session/tests/rfc1867_disabled_2.phpt index 10afe8f19d..d63748369d 100644 --- a/ext/session/tests/rfc1867_disabled_2.phpt +++ b/ext/session/tests/rfc1867_disabled_2.phpt @@ -2,8 +2,6 @@ session rfc1867 disabled 2 --INI-- file_uploads=1 -error_reporting=E_ALL&~E_NOTICE -comment=debug builds show some additional E_NOTICE errors upload_max_filesize=1024 session.save_path= session.name=PHPSESSID @@ -42,7 +40,7 @@ Content-Disposition: form-data; name="file2"; filename="file2.txt" session_start(); var_dump(session_id()); var_dump($_FILES); -var_dump($_SESSION["upload_progress_" . basename(__FILE__)]); +var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)])); session_destroy(); ?> --EXPECTF-- @@ -75,4 +73,4 @@ array(2) { int(1) } } -NULL +bool(false) diff --git a/ext/session/tests/rfc1867_inter.phpt b/ext/session/tests/rfc1867_inter.phpt index 577591feda..b961bbcac3 100644 --- a/ext/session/tests/rfc1867_inter.phpt +++ b/ext/session/tests/rfc1867_inter.phpt @@ -2,8 +2,6 @@ session rfc1867 --INI-- file_uploads=1 -error_reporting=E_ALL&~E_NOTICE -comment=debug builds show some additional E_NOTICE errors upload_max_filesize=1024 session.save_path= session.name=PHPSESSID @@ -52,7 +50,7 @@ session_start(); var_dump(session_id()); var_dump($_FILES); var_dump($_SESSION["upload_progress_" . basename(__FILE__) . "_1"]); -var_dump($_SESSION["upload_progress_" . basename(__FILE__) . "_2"]); +var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__) . "_2"])); session_destroy(); ?> --EXPECTF-- @@ -132,4 +130,4 @@ array(5) { } } } -NULL +bool(false) diff --git a/ext/session/tests/rfc1867_no_name.phpt b/ext/session/tests/rfc1867_no_name.phpt index e34f776f12..98e8e7cf09 100644 --- a/ext/session/tests/rfc1867_no_name.phpt +++ b/ext/session/tests/rfc1867_no_name.phpt @@ -2,8 +2,6 @@ session rfc1867 no name --INI-- file_uploads=1 -error_reporting=E_ALL&~E_NOTICE -comment=debug builds show some additional E_NOTICE errors upload_max_filesize=1024 session.save_path= session.name=PHPSESSID @@ -42,7 +40,7 @@ Content-Disposition: form-data; name="file2"; filename="file2.txt" session_start(); var_dump(session_id()); var_dump($_FILES); -var_dump($_SESSION["upload_progress_" . basename(__FILE__)]); +var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)])); session_destroy(); ?> --EXPECTF-- @@ -75,4 +73,4 @@ array(2) { int(1) } } -NULL +bool(false) diff --git a/ext/session/tests/rfc1867_sid_cookie.phpt b/ext/session/tests/rfc1867_sid_cookie.phpt index 6a58172f90..804a9ba308 100644 --- a/ext/session/tests/rfc1867_sid_cookie.phpt +++ b/ext/session/tests/rfc1867_sid_cookie.phpt @@ -2,8 +2,6 @@ session rfc1867 sid cookie --INI-- file_uploads=1 -error_reporting=E_ALL&~E_NOTICE -comment=debug builds show some additional E_NOTICE errors upload_max_filesize=1024 session.save_path= session.name=PHPSESSID diff --git a/ext/session/tests/rfc1867_sid_get.phpt b/ext/session/tests/rfc1867_sid_get.phpt index 089eefe967..17d1ebce0f 100644 --- a/ext/session/tests/rfc1867_sid_get.phpt +++ b/ext/session/tests/rfc1867_sid_get.phpt @@ -2,8 +2,6 @@ session rfc1867 sid get --INI-- file_uploads=1 -error_reporting=E_ALL&~E_NOTICE -comment=debug builds show some additional E_NOTICE errors upload_max_filesize=1024 session.save_path= session.name=PHPSESSID diff --git a/ext/session/tests/rfc1867_sid_get_2.phpt b/ext/session/tests/rfc1867_sid_get_2.phpt index 7cb2ffb17a..4b32c6e352 100644 --- a/ext/session/tests/rfc1867_sid_get_2.phpt +++ b/ext/session/tests/rfc1867_sid_get_2.phpt @@ -2,8 +2,6 @@ session rfc1867 sid get 2 --INI-- file_uploads=1 -error_reporting=E_ALL&~E_NOTICE -comment=debug builds show some additional E_NOTICE errors upload_max_filesize=1024 session.save_path= session.name=PHPSESSID diff --git a/ext/session/tests/rfc1867_sid_invalid.phpt b/ext/session/tests/rfc1867_sid_invalid.phpt index 881b1d5bb4..b75a9f6470 100644 --- a/ext/session/tests/rfc1867_sid_invalid.phpt +++ b/ext/session/tests/rfc1867_sid_invalid.phpt @@ -2,8 +2,6 @@ session rfc1867 sid cookie --INI-- file_uploads=1 -error_reporting=E_ALL&~E_NOTICE -comment=debug builds show some additional E_NOTICE errors upload_max_filesize=1024 session.save_path= session.name=PHPSESSID diff --git a/ext/session/tests/rfc1867_sid_only_cookie.phpt b/ext/session/tests/rfc1867_sid_only_cookie.phpt index f8f20fc3d8..0c376bb026 100644 --- a/ext/session/tests/rfc1867_sid_only_cookie.phpt +++ b/ext/session/tests/rfc1867_sid_only_cookie.phpt @@ -2,8 +2,6 @@ session rfc1867 sid only cookie --INI-- file_uploads=1 -error_reporting=E_ALL&~E_NOTICE -comment=debug builds show some additional E_NOTICE errors upload_max_filesize=1024 session.save_path= session.name=PHPSESSID diff --git a/ext/session/tests/rfc1867_sid_only_cookie_2.phpt b/ext/session/tests/rfc1867_sid_only_cookie_2.phpt index e98f4c4e3f..9b0aae9429 100644 --- a/ext/session/tests/rfc1867_sid_only_cookie_2.phpt +++ b/ext/session/tests/rfc1867_sid_only_cookie_2.phpt @@ -2,8 +2,6 @@ session rfc1867 sid only cookie 2 --INI-- file_uploads=1 -error_reporting=E_ALL&~E_NOTICE -comment=debug builds show some additional E_NOTICE errors upload_max_filesize=1024 session.save_path= session.name=PHPSESSID @@ -44,7 +42,7 @@ session_start(); var_dump(session_id()); var_dump(basename(__FILE__) == $_POST[ini_get("session.upload_progress.name")]); var_dump($_FILES); -var_dump($_SESSION["upload_progress_" . basename(__FILE__)]); +var_dump(isset($_SESSION["upload_progress_" . basename(__FILE__)])); session_destroy(); ?> --EXPECTF-- @@ -78,4 +76,4 @@ array(2) { int(1) } } -NULL +bool(false) diff --git a/ext/session/tests/rfc1867_sid_post.phpt b/ext/session/tests/rfc1867_sid_post.phpt index 51a97b900e..a126f9ba38 100644 --- a/ext/session/tests/rfc1867_sid_post.phpt +++ b/ext/session/tests/rfc1867_sid_post.phpt @@ -2,8 +2,6 @@ session rfc1867 sid post --INI-- file_uploads=1 -error_reporting=E_ALL&~E_NOTICE -comment=debug builds show some additional E_NOTICE errors upload_max_filesize=1024 session.save_path= session.name=PHPSESSID