From: Ted Kremenek <kremenek@apple.com>
Date: Fri, 11 Apr 2008 20:51:02 +0000 (+0000)
Subject: Added FIXME
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b8873558cf16893989778095cff342ae2adbc56a;p=clang

Added FIXME


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@49558 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/CFRefCount.cpp b/lib/Analysis/CFRefCount.cpp
index a9a7aaa117..27812f5a74 100644
--- a/lib/Analysis/CFRefCount.cpp
+++ b/lib/Analysis/CFRefCount.cpp
@@ -693,9 +693,13 @@ void CFRefCount::EvalCall(ExplodedNodeSet<ValueState>& Dst,
           break;
         }
       }
-    }
-    else if (isa<LVal>(V)) // Nuke all arguments passed by reference.
+    }  
+    else if (isa<LVal>(V)) { // Nuke all arguments passed by reference.
+      
+      // FIXME: This is basically copy-and-paste from GRSimpleVals.  We 
+      //  should compose behavior, not copy it.
       StateMgr.Unbind(StVals, cast<LVal>(V));
+    }
   }    
     
   if (hasError) {
@@ -733,6 +737,8 @@ void CFRefCount::EvalCall(ExplodedNodeSet<ValueState>& Dst,
     case RetEffect::NoRet:
     
       // Make up a symbol for the return value (not reference counted).
+      // FIXME: This is basically copy-and-paste from GRSimpleVals.  We 
+      //  should compose behavior, not copy it.
       
       if (CE->getType() != Eng.getContext().VoidTy) {    
         unsigned Count = Builder.getCurrentBlockCount();