From: Guido van Rossum <guido@python.org>
Date: Mon, 12 Feb 2001 22:06:02 +0000 (+0000)
Subject: Fix core dump whenever PyList_Reverse() was called.
X-Git-Tag: v2.1b1~387
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b86c549c7c41d5f8fa6f50ed3e58f3a1d62a1c4e;p=python

Fix core dump whenever PyList_Reverse() was called.

This fixes SF bug #132008, reported by Warren J. Hack.

The copyright for this patch (and this patch only) belongs to CNRI, as
part of the (yet to be issued) 1.6.1 release.

This is now checked into the HEAD branch.  Tim will check in a test
case to check for this specific bug, and an assertion in
PyArgs_ParseTuple() to catch similar bugs in the future.
---

diff --git a/Objects/listobject.c b/Objects/listobject.c
index f57f6fbed8..0087c63521 100644
--- a/Objects/listobject.c
+++ b/Objects/listobject.c
@@ -1268,24 +1268,30 @@ PyList_Sort(PyObject *v)
 	return 0;
 }
 
-static PyObject *
-listreverse(PyListObject *self, PyObject *args)
+static void
+_listreverse(PyListObject *self)
 {
 	register PyObject **p, **q;
 	register PyObject *tmp;
 	
-	if (!PyArg_ParseTuple(args, ":reverse"))
-		return NULL;
-
 	if (self->ob_size > 1) {
 		for (p = self->ob_item, q = self->ob_item + self->ob_size - 1;
-						p < q; p++, q--) {
+		     p < q;
+		     p++, q--)
+		{
 			tmp = *p;
 			*p = *q;
 			*q = tmp;
 		}
 	}
-	
+}
+
+static PyObject *
+listreverse(PyListObject *self, PyObject *args)
+{
+	if (!PyArg_ParseTuple(args, ":reverse"))
+		return NULL;
+	_listreverse(self);
 	Py_INCREF(Py_None);
 	return Py_None;
 }
@@ -1297,10 +1303,7 @@ PyList_Reverse(PyObject *v)
 		PyErr_BadInternalCall();
 		return -1;
 	}
-	v = listreverse((PyListObject *)v, (PyObject *)NULL);
-	if (v == NULL)
-		return -1;
-	Py_DECREF(v);
+	_listreverse((PyListObject *)v);
 	return 0;
 }