From: Peter Collingbourne <peter@pcc.me.uk>
Date: Thu, 7 Jul 2016 01:51:11 +0000 (+0000)
Subject: ThinLTO: Remove check for multiple modules before applying weak resolutions.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b821e278a9745727b9d6c8f356153fc5fb6a4ba9;p=llvm

ThinLTO: Remove check for multiple modules before applying weak resolutions.

This check is not only unnecessary, it can produce the wrong result. If we
are linking a single module and it has an exported linkonce symbol, we need
to promote to weak in order to avoid PR19901-style problems.

Differential Revision: http://reviews.llvm.org/D21917

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@274722 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/LTO/LTO.cpp b/lib/LTO/LTO.cpp
index 094b0c6b31a..11bfc94082e 100644
--- a/lib/LTO/LTO.cpp
+++ b/lib/LTO/LTO.cpp
@@ -92,10 +92,6 @@ void thinLTOResolveWeakForLinkerInIndex(
     function_ref<bool(StringRef, GlobalValue::GUID)> isExported,
     function_ref<void(StringRef, GlobalValue::GUID, GlobalValue::LinkageTypes)>
         recordNewLinkage) {
-  if (Index.modulePaths().size() == 1)
-    // Nothing to do if we don't have multiple modules
-    return;
-
   // We won't optimize the globals that are referenced by an alias for now
   // Ideally we should turn the alias into a global and duplicate the definition
   // when needed.
diff --git a/test/ThinLTO/X86/weak_resolution_single.ll b/test/ThinLTO/X86/weak_resolution_single.ll
new file mode 100644
index 00000000000..79bf5f39322
--- /dev/null
+++ b/test/ThinLTO/X86/weak_resolution_single.ll
@@ -0,0 +1,9 @@
+; RUN: opt -module-summary %s -o %t.bc
+; RUN: llvm-lto -thinlto-action=thinlink -o %t2.bc %t.bc
+
+; RUN: llvm-lto -thinlto-action=promote %t.bc -thinlto-index=%t2.bc -exported-symbol=foo -o - | llvm-lto -thinlto-action=internalize -thinlto-module-id=%t.bc - -thinlto-index=%t2.bc -exported-symbol=foo -o - | llvm-dis -o - | FileCheck %s
+
+; CHECK: define weak_odr void @foo()
+define linkonce_odr void @foo() {
+  ret void
+}