From: Chandler Carruth Date: Sun, 1 May 2011 01:05:51 +0000 (+0000) Subject: Switch the interface name for both TemplateTypeParmType and X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b7efff4bae117604f442bb6859c844f90b15f3ff;p=clang Switch the interface name for both TemplateTypeParmType and SubstTemplateTypeParmType to be 'getIdentifier' instead of 'getName' as it returns an identifier. This makes them more consistent with the NamedDecl interface. Also, switch back to using this interface to acquire the indentifier in TypePrinter.cpp. I missed this in r130628. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@130629 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/clang/AST/CanonicalType.h b/include/clang/AST/CanonicalType.h index ce2b3cdea4..b3550f8773 100644 --- a/include/clang/AST/CanonicalType.h +++ b/include/clang/AST/CanonicalType.h @@ -656,7 +656,7 @@ struct CanProxyAdaptor LLVM_CLANG_CANPROXY_SIMPLE_ACCESSOR(unsigned, getIndex) LLVM_CLANG_CANPROXY_SIMPLE_ACCESSOR(bool, isParameterPack) LLVM_CLANG_CANPROXY_SIMPLE_ACCESSOR(TemplateTypeParmDecl *, getDecl) - LLVM_CLANG_CANPROXY_SIMPLE_ACCESSOR(IdentifierInfo *, getName) + LLVM_CLANG_CANPROXY_SIMPLE_ACCESSOR(IdentifierInfo *, getIdentifier) }; template<> diff --git a/include/clang/AST/Type.h b/include/clang/AST/Type.h index cd7138de69..a49992189e 100644 --- a/include/clang/AST/Type.h +++ b/include/clang/AST/Type.h @@ -3015,7 +3015,7 @@ public: return isCanonicalUnqualified() ? 0 : TTPDecl; } - IdentifierInfo *getName() const; + IdentifierInfo *getIdentifier() const; bool isSugared() const { return false; } QualType desugar() const { return QualType(this, 0); } @@ -3119,7 +3119,7 @@ class SubstTemplateTypeParmPackType : public Type, public llvm::FoldingSetNode { friend class ASTContext; public: - IdentifierInfo *getName() const { return Replaced->getName(); } + IdentifierInfo *getIdentifier() const { return Replaced->getIdentifier(); } /// Gets the template parameter that was substituted for. const TemplateTypeParmType *getReplacedParameter() const { diff --git a/lib/AST/Type.cpp b/lib/AST/Type.cpp index 1ed1770426..9eb497bea6 100644 --- a/lib/AST/Type.cpp +++ b/lib/AST/Type.cpp @@ -1504,7 +1504,7 @@ bool EnumType::classof(const TagType *TT) { return isa(TT->getDecl()); } -IdentifierInfo *TemplateTypeParmType::getName() const { +IdentifierInfo *TemplateTypeParmType::getIdentifier() const { return isCanonicalUnqualified() ? 0 : getDecl()->getIdentifier(); } diff --git a/lib/AST/TypePrinter.cpp b/lib/AST/TypePrinter.cpp index a0d40e14d7..0c5df7fae6 100644 --- a/lib/AST/TypePrinter.cpp +++ b/lib/AST/TypePrinter.cpp @@ -653,7 +653,7 @@ void TypePrinter::printTemplateTypeParm(const TemplateTypeParmType *T, if (!S.empty()) // Prefix the basic type, e.g. 'parmname X'. S = ' ' + S; - if (IdentifierInfo *Id = T->getDecl() ? T->getDecl()->getIdentifier() : 0) + if (IdentifierInfo *Id = T->getIdentifier()) S = Id->getName().str() + S; else S = "type-parameter-" + llvm::utostr_32(T->getDepth()) + '-' + diff --git a/lib/Sema/SemaTemplateVariadic.cpp b/lib/Sema/SemaTemplateVariadic.cpp index 5c321fd6df..096d353bcc 100644 --- a/lib/Sema/SemaTemplateVariadic.cpp +++ b/lib/Sema/SemaTemplateVariadic.cpp @@ -167,7 +167,7 @@ DiagnoseUnexpandedParameterPacks(Sema &S, SourceLocation Loc, IdentifierInfo *Name = 0; if (const TemplateTypeParmType *TTP = Unexpanded[I].first.dyn_cast()) - Name = TTP->getName(); + Name = TTP->getIdentifier(); else Name = Unexpanded[I].first.get()->getIdentifier(); @@ -483,7 +483,7 @@ bool Sema::CheckParameterPacksForExpansion(SourceLocation EllipsisLoc, = Unexpanded[I].first.dyn_cast()) { Depth = TTP->getDepth(); Index = TTP->getIndex(); - Name = TTP->getName(); + Name = TTP->getIdentifier(); } else { NamedDecl *ND = Unexpanded[I].first.get(); if (isa(ND))