From: Matt Caswell <matt@openssl.org>
Date: Thu, 4 Jun 2015 10:16:16 +0000 (+0100)
Subject: Clean premaster_secret for GOST
X-Git-Tag: OpenSSL_1_1_0-pre1~1034
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b7ee4815f2452c854cc859e8dda88f2673cdddea;p=openssl

Clean premaster_secret for GOST

Ensure OPENSSL_cleanse() is called on the premaster secret value calculated for GOST.

With thanks to the Open Crypto Audit Project for reporting this issue.

Reviewed-by: Rich Salz <rsalz@openssl.org>
---

diff --git a/ssl/s3_srvr.c b/ssl/s3_srvr.c
index 88e649d315..90a67d1105 100644
--- a/ssl/s3_srvr.c
+++ b/ssl/s3_srvr.c
@@ -2825,6 +2825,7 @@ int ssl3_get_client_key_exchange(SSL *s)
                                                         s->
                                                         session->master_key,
                                                         premaster_secret, 32);
+        OPENSSL_cleanse(premaster_secret, sizeof(premaster_secret));
         if (s->session->master_key_length < 0) {
             al = SSL_AD_INTERNAL_ERROR;
             SSLerr(SSL_F_SSL3_GET_CLIENT_KEY_EXCHANGE, ERR_R_INTERNAL_ERROR);