From: Christoph M. Becker <cmbecker69@gmx.de>
Date: Wed, 7 Nov 2018 15:37:00 +0000 (+0100)
Subject: Avoid needless string duplication
X-Git-Tag: php-7.4.0alpha1~1573
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b7b3a65e1db210570fe7df8bec43ee4c29620ba3;p=php

Avoid needless string duplication

Cf. <https://github.com/php/php-src/pull/3636#issuecomment-436638833>.
---

diff --git a/ext/sqlite3/sqlite3.c b/ext/sqlite3/sqlite3.c
index 2abf99f4eb..1b24af074f 100644
--- a/ext/sqlite3/sqlite3.c
+++ b/ext/sqlite3/sqlite3.c
@@ -1415,7 +1415,7 @@ static int register_bound_parameter_to_sqlite(struct php_sqlite3_bound_param *pa
 			memmove(ZSTR_VAL(temp) + 1, ZSTR_VAL(param->name), ZSTR_LEN(param->name) + 1);
 			param->name = temp;
 		} else {
-			param->name = zend_string_init(ZSTR_VAL(param->name), ZSTR_LEN(param->name), 0);
+			param->name = zend_string_copy(param->name);
 		}
 		/* do lookup*/
 		param->param_number = sqlite3_bind_parameter_index(stmt->stmt, ZSTR_VAL(param->name));