From: Guido van Rossum <guido@python.org>
Date: Wed, 19 Feb 2003 17:50:16 +0000 (+0000)
Subject: The connect timeout code wasn't working on Windows.
X-Git-Tag: v2.3c1~1758
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b76bdf8ef7044145efb0bc74d513c867d29af4d1;p=python

The connect timeout code wasn't working on Windows.

Rather than trying to second-guess the various error returns
of a second connect(), use select() to determine whether the
socket becomes writable (which means connected).
---

diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index 1b3321f5d0..2b8e3ea51f 100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -1336,18 +1336,19 @@ internal_connect(PySocketSockObject *s, struct sockaddr *addr, int addrlen)
 
 	if (s->sock_timeout > 0.0) {
 		if (res < 0 && WSAGetLastError() == WSAEWOULDBLOCK) {
-			internal_select(s, 1);
-			res = connect(s->sock_fd, addr, addrlen);
-			if (res < 0) {
-				/* On Win98, WSAEISCONN was seen here.  But
-				 * on Win2K, WSAEINVAL.  So accept both as
-				 * meaning "fine".
-				 */
-				int code = WSAGetLastError();
-				if (code == WSAEISCONN ||
-				    code == WSAEINVAL)
-					res = 0;
-			}
+			/* This is a mess.  Best solution: trust select */
+			fd_set fds;
+			struct timeval tv;
+			tv.tv_sec = (int)s->sock_timeout;
+			tv.tv_usec = (int)((s->sock_timeout - tv.tv_sec) * 1e6);
+			FD_ZERO(&fds);
+			FD_SET(s->sock_fd, &fds);
+			res = select(s->sock_fd+1, NULL, &fds, NULL, &tv);
+			if (res == 0)
+				res = WSAEWOULDBLOCK;
+			else if (res > 0)
+				res = 0;
+			/* else if (res < 0) an error occurred */
 		}
 	}