From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 3 Oct 2011 16:13:15 +0000 (-0400)
Subject: ProcedureCreate neglected to record dependencies on default expressions.
X-Git-Tag: REL9_1_2~90
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b733331d0fe0ecb36aa629f187876734da25ea80;p=postgresql

ProcedureCreate neglected to record dependencies on default expressions.

Thus, an object referenced in a default expression could be dropped while
the function remained present.  This was unaccountably missed in the
original patch to add default parameters for functions.  Reported by
Pavel Stehule.
---

diff --git a/src/backend/catalog/pg_proc.c b/src/backend/catalog/pg_proc.c
index 18a2c1a3c0..72559daf54 100644
--- a/src/backend/catalog/pg_proc.c
+++ b/src/backend/catalog/pg_proc.c
@@ -598,6 +598,11 @@ ProcedureCreate(const char *procedureName,
 		recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL);
 	}
 
+	/* dependency on parameter default expressions */
+	if (parameterDefaults)
+		recordDependencyOnExpr(&myself, (Node *) parameterDefaults,
+							   NIL, DEPENDENCY_NORMAL);
+
 	/* dependency on owner */
 	if (!is_update)
 		recordDependencyOnOwner(ProcedureRelationId, retval, proowner);