From: Jim Warner <james.warner@comcast.net>
Date: Mon, 6 Jun 2016 05:00:00 +0000 (-0500)
Subject: library: whack a superfluous assignment, <MEMINFO> api
X-Git-Tag: v4.0.0~880
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b700d91f84c8fe5b5a32cfd9ed5c50f37ea82bb4;p=procps-ng

library: whack a superfluous assignment, <MEMINFO> api

This patch was prompted through work on the <slabinfo>
upgrade from 2nd gen to 3rd. And while this assignment
caused no real harm, it most certainly was misleading.

[ plus add a couple of overlooked #undef directives! ]

Signed-off-by: Jim Warner <james.warner@comcast.net>
---

diff --git a/proc/meminfo.c b/proc/meminfo.c
index 3e7064be..38dc8a62 100644
--- a/proc/meminfo.c
+++ b/proc/meminfo.c
@@ -460,6 +460,8 @@ enum meminfo_item PROCPS_MEMINFO_logical_end = PROCPS_MEMINFO_SWAP_USED + 1;
 #undef getDECL
 #undef MEM_get
 #undef HST_get
+#undef RS
+#undef RG
 
 // ___ Private Functions ||||||||||||||||||||||||||||||||||||||||||||||||||||||
 
@@ -1002,7 +1004,7 @@ PROCPS_EXPORT struct meminfo_stack *procps_meminfo_select (
             extents_free_all(info);
     }
     if (!info->extents
-    && !(info->extents = stacks_alloc(info, 1)))
+    && !(stacks_alloc(info, 1)))
        return NULL;
 
     if (info->dirty_stacks)