From: Matt Caswell <matt@openssl.org>
Date: Sun, 10 Dec 2017 09:55:08 +0000 (+0000)
Subject: Fix a switch statement fallthrough
X-Git-Tag: OpenSSL_1_0_2o~59
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b6adfa043fcd33960c277a75984701e87d06fa33;p=openssl

Fix a switch statement fallthrough

SSL_trace() has a case which was inadvertently falling through.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4888)

(cherry picked from commit 5bfb357a0d2046fc75daf67a5bc019eb87443729)
---

diff --git a/ssl/t1_trce.c b/ssl/t1_trce.c
index c5e21df77a..dc62df8f94 100644
--- a/ssl/t1_trce.c
+++ b/ssl/t1_trce.c
@@ -1247,13 +1247,15 @@ void SSL_trace(int write_p, int version, int content_type,
         break;
 
     case SSL3_RT_ALERT:
-        if (msglen != 2)
+        if (msglen != 2) {
             BIO_puts(bio, "    Illegal Alert Length\n");
-        else {
+        } else {
             BIO_printf(bio, "    Level=%s(%d), description=%s(%d)\n",
                        SSL_alert_type_string_long(msg[0] << 8),
                        msg[0], SSL_alert_desc_string_long(msg[1]), msg[1]);
         }
+        break;
+
     case TLS1_RT_HEARTBEAT:
         ssl_print_heartbeat(bio, 4, msg, msglen);
         break;