From: Nico Weber <nicolasweber@gmx.de>
Date: Tue, 5 Feb 2019 23:48:13 +0000 (+0000)
Subject: gn build: Fix clang-tidy build
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b6644eccc0a572b0c85525698df1eca65b067c8d;p=llvm

gn build: Fix clang-tidy build

Not depending on //clang/lib/StaticAnalyzer/Core and
//clang/lib/StaticAnalyzer/Frontend causes a linker error even if
ClangSACheckers are not supported.

Undefined symbols for architecture x86_64:
  "clang::ento::CreateAnalysisConsumer(clang::CompilerInstance&)", referenced from:
      clang::tidy::ClangTidyASTConsumerFactory::CreateASTConsumer(
              clang::CompilerInstance&, llvm::StringRef)
          in libclangTidy.a(libclangTidy.ClangTidy.o)

Patch from Mirko Bonadei <mbonadei@webrtc.org>!

Differential Revision: https://reviews.llvm.org/D57777


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@353244 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn b/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
index 3356f0f6cf2..4d233e987fe 100644
--- a/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
+++ b/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn
@@ -22,14 +22,12 @@ static_library("clang-tidy") {
     # ClangSACheckers
   ]
 
-  # TODO(mbonadei): Add support for Clang Static Analyzer checkers.
-  # Without this, "clang-analyzer-" will not work.
-  # if (clang_enable_static_analyzer) {
-  #   deps += [
-  #     "//clang/lib/StaticAnalyzer/Core",
-  #     "//clang/lib/StaticAnalyzer/Frontend",
-  #   ]
-  # }
+  if (clang_enable_static_analyzer) {
+    deps += [
+      "//clang/lib/StaticAnalyzer/Core",
+      "//clang/lib/StaticAnalyzer/Frontend",
+    ]
+  }
 
   sources = [
     "ClangTidy.cpp",