From: Jay Satiro <raysatiro@yahoo.com>
Date: Wed, 16 Nov 2016 07:16:10 +0000 (-0500)
Subject: http2: Fix address sanitizer memcpy warning
X-Git-Tag: curl-7_52_0~115
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b65f79d9e84277594f0df98ae4b997053176983d;p=curl

http2: Fix address sanitizer memcpy warning

- In Curl_http2_switched don't call memcpy when src is NULL.

Curl_http2_switched can be called like:

Curl_http2_switched(conn, NULL, 0);

.. and prior to this change memcpy was then called like:

memcpy(dest, NULL, 0)

.. causing address sanitizer to warn:

http2.c:2057:3: runtime error: null pointer passed as argument 2, which
is declared to never be null
---

diff --git a/lib/http2.c b/lib/http2.c
index 1484e1515..6720984b0 100644
--- a/lib/http2.c
+++ b/lib/http2.c
@@ -2054,7 +2054,8 @@ CURLcode Curl_http2_switched(struct connectdata *conn,
                     " after upgrade: len=%zu\n",
         nread);
 
-  memcpy(httpc->inbuf, mem, nread);
+  if(nread)
+    memcpy(httpc->inbuf, mem, nread);
   httpc->inbuflen = nread;
 
   nproc = nghttp2_session_mem_recv(httpc->h2, (const uint8_t *)httpc->inbuf,