From: Daniel Dunbar <daniel@zuster.org>
Date: Wed, 18 Feb 2009 22:52:09 +0000 (+0000)
Subject: Add anti-FIXME.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b5da3e94b72a0106abd69c2a84bf650e773fa4ac;p=clang

Add anti-FIXME.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@64969 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp
index 312eaad297..e7c784580b 100644
--- a/lib/CodeGen/CodeGenModule.cpp
+++ b/lib/CodeGen/CodeGenModule.cpp
@@ -162,7 +162,10 @@ static void setGlobalVisibility(llvm::GlobalValue *GV,
 /// FIXME: Returning an IdentifierInfo* here is a total hack. We
 /// really need some kind of string abstraction that either stores a
 /// mangled name or stores an IdentifierInfo*. This will require
-/// changes to the GlobalDeclMap, too.
+/// changes to the GlobalDeclMap, too. (I disagree, I think what we
+/// actually need is for Sema to provide some notion of which Decls
+/// refer to the same semantic decl. We shouldn't need to mangle the
+/// names and see what comes out the same to figure this out. - DWD)
 ///
 /// FIXME: Performance here is going to be terribly until we start
 /// caching mangled names. However, we should fix the problem above