From: Raymond Hettinger <python@rcn.com>
Date: Mon, 1 Sep 2003 22:25:41 +0000 (+0000)
Subject: SF patch #798534:  Windows os.popen needlessly gets a reference to tuple ()
X-Git-Tag: v2.4a1~1674
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b5cb66542d76d303fe0f30ef194788e1fcfbba79;p=python

SF patch #798534:  Windows os.popen needlessly gets a reference to tuple ()
(Contributed by Andrew Gaul.)

Fixes a minor leak.
---

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index b8bda3b5e4..40526a465e 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -3615,7 +3615,7 @@ static PyObject *_PyPopenProcs = NULL;
 static PyObject *
 posix_popen(PyObject *self, PyObject *args)
 {
-	PyObject *f, *s;
+	PyObject *f;
 	int tm = 0;
 
 	char *cmdstring;
@@ -3624,8 +3624,6 @@ posix_popen(PyObject *self, PyObject *args)
 	if (!PyArg_ParseTuple(args, "s|si:popen", &cmdstring, &mode, &bufsize))
 		return NULL;
 
-	s = PyTuple_New(0);
-
 	if (*mode == 'r')
 		tm = _O_RDONLY;
 	else if (*mode != 'w') {