From: Etsuro Fujita <efujita@postgresql.org>
Date: Tue, 12 Mar 2019 07:21:57 +0000 (+0900)
Subject: Fix testing of parallel-safety of scan/join target.
X-Git-Tag: REL_12_BETA1~559
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b5afdde6a7bb777d399b20da6fb8a664a1cd2784;p=postgresql

Fix testing of parallel-safety of scan/join target.

In commit 960df2a971 ("Correctly assess parallel-safety of tlists when
SRFs are used."), the testing of scan/join target was done incorrectly,
which caused a plan-quality problem.  Backpatch through to v11 where
the aforementioned commit went in, since this is a regression from v10.

Author: Etsuro Fujita
Reviewed-by: Robert Haas and Tom Lane
Discussion: https://postgr.es/m/5C75303E.8020303@lab.ntt.co.jp
---

diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c
index 5e3a7120ff..9bb068a52e 100644
--- a/src/backend/optimizer/plan/planner.c
+++ b/src/backend/optimizer/plan/planner.c
@@ -1993,7 +1993,7 @@ grouping_planner(PlannerInfo *root, bool inheritance_update,
 		{
 			scanjoin_target = make_group_input_target(root, final_target);
 			scanjoin_target_parallel_safe =
-				is_parallel_safe(root, (Node *) grouping_target->exprs);
+				is_parallel_safe(root, (Node *) scanjoin_target->exprs);
 		}
 		else
 		{