From: Michael Friedrich <michael.friedrich@icinga.com>
Date: Thu, 12 Apr 2018 17:24:08 +0000 (+0200)
Subject: Fix error handling on config package delete
X-Git-Tag: v2.9.0~89^2~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b53685db594035ea23408946ce4623c5591a364e;p=icinga2

Fix error handling on config package delete
---

diff --git a/lib/remote/configpackageshandler.cpp b/lib/remote/configpackageshandler.cpp
index 2ecf78d4c..8ad25d0cb 100644
--- a/lib/remote/configpackageshandler.cpp
+++ b/lib/remote/configpackageshandler.cpp
@@ -135,12 +135,13 @@ void ConfigPackagesHandler::HandleDelete(const ApiUser::Ptr& user, HttpRequest&
 	} catch (const std::exception& ex) {
 		HttpUtility::SendJsonError(response, params, 500, "Failed to delete package '" + packageName + "'.",
 			DiagnosticInformation(ex));
+		return;
 	}
 
 	Dictionary::Ptr result1 = new Dictionary({
 		{ "code", 200 },
 		{ "package", packageName },
-		{ "status", "Created package." }
+		{ "status", "Deleted package." }
 	});
 
 	Dictionary::Ptr result = new Dictionary({