From: Levi Morrison <levim@php.net>
Date: Fri, 5 Sep 2014 22:07:07 +0000 (-0600)
Subject: Error on multiple default blocks in a switch
X-Git-Tag: POST_NATIVE_TLS_MERGE^2~263^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b476eca8261095f1853764c9a8ac2938a71e85d1;p=php

Error on multiple default blocks in a switch

Part of RFC: https://wiki.php.net/rfc/switch.default.multiple
---

diff --git a/Zend/tests/034.phpt b/Zend/tests/034.phpt
index 6e46f2645e..0bcfa23f19 100644
--- a/Zend/tests/034.phpt
+++ b/Zend/tests/034.phpt
@@ -22,5 +22,5 @@ switch (1) {
 }
 
 ?>
---EXPECT--
-3
+--EXPECTF--
+Fatal error: Switch statements may only contain one default clause in %s on line 13
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
index a5a32298d5..3af97ccc02 100644
--- a/Zend/zend_compile.c
+++ b/Zend/zend_compile.c
@@ -5091,6 +5091,11 @@ void zend_compile_switch(zend_ast *ast TSRMLS_DC) /* {{{ */
 		znode cond_node;
 
 		if (!cond_ast) {
+			if (has_default_case) {
+				CG(zend_lineno) = case_ast->lineno;
+				zend_error_noreturn(E_COMPILE_ERROR,
+					"Switch statements may only contain one default clause");
+			}
 			has_default_case = 1;
 			continue;
 		}