From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sat, 18 Oct 2014 02:55:23 +0000 (-0400)
Subject: Declare mkdtemp() only if we're providing it.
X-Git-Tag: REL9_4_RC1~74
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b45f048ed899502c982f249d90608ca09b7939e7;p=postgresql

Declare mkdtemp() only if we're providing it.

Follow our usual style of providing an "extern" for a standard library
function only when we're also providing the implementation.  This avoids
issues when the system headers declare the function slightly differently
than we do, as noted by Caleb Welton.

We might have to go to the extent of probing to see if the system headers
declare the function, but let's not do that until it's demonstrated to be
necessary.

Oversight in commit 9e6b1bf258170e62dac555fc82ff0536dfe01d29.  Back-patch
to all supported branches, as that was.
---

diff --git a/src/include/port.h b/src/include/port.h
index 9f8465e78a..94a0e2fe2b 100644
--- a/src/include/port.h
+++ b/src/include/port.h
@@ -390,6 +390,10 @@ extern int	getpeereid(int sock, uid_t *uid, gid_t *gid);
 extern int	isinf(double x);
 #endif
 
+#ifndef HAVE_MKDTEMP
+extern char *mkdtemp(char *path);
+#endif
+
 #ifndef HAVE_RINT
 extern double rint(double x);
 #endif
@@ -466,9 +470,6 @@ extern int	pg_check_dir(const char *dir);
 /* port/pgmkdirp.c */
 extern int	pg_mkdir_p(char *path, int omode);
 
-/* port/mkdtemp.c */
-extern char *mkdtemp(char *path);
-
 /* port/pqsignal.c */
 typedef void (*pqsigfunc) (int signo);
 extern pqsigfunc pqsignal(int signo, pqsigfunc func);