From: Matt Caswell <matt@openssl.org>
Date: Wed, 27 Apr 2016 13:22:20 +0000 (+0100)
Subject: Don't leak memory on error path in dane_ctx_enable()
X-Git-Tag: OpenSSL_1_1_0-pre6~1023
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b3bd3d5af8ed31f438db4367ce3a4bd43067e764;p=openssl

Don't leak memory on error path in dane_ctx_enable()

The function dane_ctx_enable() allocated some memory that it did not
free in an error path.

Reviewed-by: Richard Levitte <levitte@openssl.org>
---

diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c
index f93b98f42f..99d88b31ee 100644
--- a/ssl/ssl_lib.c
+++ b/ssl/ssl_lib.c
@@ -215,6 +215,7 @@ static int dane_ctx_enable(struct dane_ctx_st *dctx)
     mdord = OPENSSL_zalloc(n * sizeof(*mdord));
 
     if (mdord == NULL || mdevp == NULL) {
+        OPENSSL_free(mdord);
         OPENSSL_free(mdevp);
         SSLerr(SSL_F_DANE_CTX_ENABLE, ERR_R_MALLOC_FAILURE);
         return 0;