From: Michael Paquier <michael@paquier.xyz>
Date: Thu, 28 Feb 2019 02:02:11 +0000 (+0900)
Subject: Improve documentation of data_sync_retry
X-Git-Tag: REL_12_BETA1~658
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b3a156858ab03cb5f9c55dedcaf85a6249b3ec64;p=postgresql

Improve documentation of data_sync_retry

Reflecting an updated parameter value requires a server restart, which
was not mentioned in the documentation and in postgresql.conf.sample.

Reported-by: Thomas Poty
Discussion: https://postgr.es/m/15659-0cd812f13027a2d8@postgresql.org
---

diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 1c3b7affa9..6d42b7afe7 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -8791,7 +8791,8 @@ dynamic_library_path = 'C:\tools\postgresql;H:\my_project\lib;$libdir'
        <para>
         When set to off, which is the default, <productname>PostgreSQL</productname>
         will raise a PANIC-level error on failure to flush modified data files
-        to the filesystem.  This causes the database server to crash.
+        to the filesystem.  This causes the database server to crash.  This
+        parameter can only be set at server start.
        </para>
        <para>
         On some operating systems, the status of data in the kernel's page
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index 194f312096..bd6ea65d0c 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -719,7 +719,9 @@
 
 #exit_on_error = off			# terminate session on any error?
 #restart_after_crash = on		# reinitialize after backend crash?
-#data_sync_retry = off			# retry or panic on failure to fsync data?
+#data_sync_retry = off			# retry or panic on failure to fsync
+					# data?
+					# (change requires restart)
 
 
 #------------------------------------------------------------------------------