From: Victor Stinner <victor.stinner@gmail.com>
Date: Fri, 27 Feb 2015 16:47:23 +0000 (+0100)
Subject: Issue #23526: Fix ResourceWarning in test_httplib. Patch written by Alex Shkop.
X-Git-Tag: v3.5.0a2~77^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b389b482659a0633d84f15307c9605cc0bf28633;p=python

Issue #23526: Fix ResourceWarning in test_httplib. Patch written by Alex Shkop.
---

diff --git a/Lib/test/test_httplib.py b/Lib/test/test_httplib.py
index d0a0e8de81..4c578676cb 100644
--- a/Lib/test/test_httplib.py
+++ b/Lib/test/test_httplib.py
@@ -840,6 +840,7 @@ class HTTPSTest(TestCase):
                                        context=context)
             h.request('GET', '/')
             resp = h.getresponse()
+            h.close()
             self.assertIn('nginx', resp.getheader('server'))
 
     @support.system_must_validate_cert
@@ -851,6 +852,7 @@ class HTTPSTest(TestCase):
             h.request('GET', '/')
             resp = h.getresponse()
             content_type = resp.getheader('content-type')
+            h.close()
             self.assertIn('text/html', content_type)
 
     def test_networked_good_cert(self):
@@ -865,6 +867,7 @@ class HTTPSTest(TestCase):
             h.request('GET', '/')
             resp = h.getresponse()
             server_string = resp.getheader('server')
+            h.close()
             self.assertIn('nginx', server_string)
 
     def test_networked_bad_cert(self):
diff --git a/Misc/ACKS b/Misc/ACKS
index 71f4048381..20598abb74 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1247,6 +1247,7 @@ Alexander Shigin
 Pete Shinners
 Michael Shiplett
 John W. Shipman
+Alex Shkop
 Joel Shprentz
 Yue Shuaijie
 Terrel Shumway