From: Eric Smith <eric@trueblade.com>
Date: Fri, 16 Oct 2009 14:26:36 +0000 (+0000)
Subject: Removed usage of unsafe PyFloat_AsString.
X-Git-Tag: v2.7a1~334
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b327258d4fa85ee7e30bfb4377230018857d0eaf;p=python

Removed usage of unsafe PyFloat_AsString.
---

diff --git a/Objects/floatobject.c b/Objects/floatobject.c
index 73d6a1ff41..745fe54226 100644
--- a/Objects/floatobject.c
+++ b/Objects/floatobject.c
@@ -2012,15 +2012,21 @@ PyFloat_Fini(void)
 			     i++, p++) {
 				if (PyFloat_CheckExact(p) &&
 				    Py_REFCNT(p) != 0) {
-					char buf[100];
-					PyFloat_AsString(buf, p);
-					/* XXX(twouters) cast refcount to
-					   long until %zd is universally
-					   available
-					 */
-					fprintf(stderr,
+					char *buf = PyOS_double_to_string(
+						PyFloat_AS_DOUBLE(p), 'r',
+						0, 0, NULL);
+					if (buf) {
+						/* XXX(twouters) cast
+						   refcount to long
+						   until %zd is
+						   universally
+						   available
+						*/
+						fprintf(stderr,
 			     "#   <float at %p, refcnt=%ld, val=%s>\n",
 						p, (long)Py_REFCNT(p), buf);
+						PyMem_Free(buf);
+					}
 				}
 			}
 			list = list->next;