From: Robert Haas <rhaas@postgresql.org>
Date: Wed, 27 Jul 2016 14:16:26 +0000 (-0400)
Subject: Fix thinko in copyParamList.
X-Git-Tag: REL9_6_BETA4~83
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b31875b1fe7131ac29f118efd81c9aba7255eced;p=postgresql

Fix thinko in copyParamList.

There's no point in consulting retval->paramMask; it's always NULL.
Instead, we should consult from->paramMask.

Reported by Andrew Gierth.
---

diff --git a/src/backend/nodes/params.c b/src/backend/nodes/params.c
index d7d513e78f..f2e26b80c4 100644
--- a/src/backend/nodes/params.c
+++ b/src/backend/nodes/params.c
@@ -61,8 +61,8 @@ copyParamList(ParamListInfo from)
 		bool		typByVal;
 
 		/* Ignore parameters we don't need, to save cycles and space. */
-		if (retval->paramMask != NULL &&
-			!bms_is_member(i, retval->paramMask))
+		if (from->paramMask != NULL &&
+			!bms_is_member(i, from->paramMask))
 		{
 			nprm->value = (Datum) 0;
 			nprm->isnull = true;