From: Neil Schemenauer <nascheme@enme.ucalgary.ca>
Date: Mon, 2 Nov 2009 00:59:52 +0000 (+0000)
Subject: Fix broken test in test_hotshot.  Treating the current directory as an
X-Git-Tag: v2.6.5rc1~389
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b29642f1297613f84c6678628b12a2bd5e3ae60a;p=python

Fix broken test in test_hotshot.  Treating the current directory as an
empty file is sloppy and non-portable.  Use NamedTemporaryFile to make
an empty file.
---

diff --git a/Lib/test/test_hotshot.py b/Lib/test/test_hotshot.py
index 35ca6aa7f7..fa6b2f1629 100644
--- a/Lib/test/test_hotshot.py
+++ b/Lib/test/test_hotshot.py
@@ -3,6 +3,7 @@ import hotshot.log
 import os
 import pprint
 import unittest
+import tempfile
 import _hotshot
 import gc
 
@@ -127,7 +128,12 @@ class HotShotTestCase(unittest.TestCase):
                 os.remove(test_support.TESTFN)
 
     def test_logreader_eof_error(self):
-        self.assertRaises((IOError, EOFError), _hotshot.logreader, ".")
+        emptyfile = tempfile.NamedTemporaryFile()
+        try:
+            self.assertRaises((IOError, EOFError), _hotshot.logreader,
+                              emptyfile.name)
+        finally:
+            emptyfile.close()
         gc.collect()
 
 def test_main():