From: Mehdi Amini <mehdi.amini@apple.com>
Date: Fri, 23 Dec 2016 02:20:09 +0000 (+0000)
Subject: MetadataLoader: Add an assertion for the implicit invariant of PlaceHolder while... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b1c75432e5d22daefebf89e3386c1797aa8f57f6;p=llvm

MetadataLoader: Add an assertion for the implicit invariant of PlaceHolder while loading Metadata (NFC)

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@290408 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Bitcode/Reader/MetadataLoader.cpp b/lib/Bitcode/Reader/MetadataLoader.cpp
index 1cfa1a82182..93212b0aa77 100644
--- a/lib/Bitcode/Reader/MetadataLoader.cpp
+++ b/lib/Bitcode/Reader/MetadataLoader.cpp
@@ -372,8 +372,14 @@ DistinctMDOperandPlaceholder &PlaceholderQueue::getPlaceholderOp(unsigned ID) {
 
 void PlaceholderQueue::flush(BitcodeReaderMetadataList &MetadataList) {
   while (!PHs.empty()) {
-    PHs.front().replaceUseWith(
-        MetadataList.getMetadataFwdRef(PHs.front().getID()));
+    auto *MD = MetadataList.getMetadataFwdRef(PHs.front().getID());
+#ifndef NDEBUG
+    if (auto MDN = dyn_cast<MDNode>(MD)) {
+      assert(MDN->isResolved() &&
+             "Flushing Placeholder while cycles aren't resolved");
+    }
+#endif
+    PHs.front().replaceUseWith(MD);
     PHs.pop_front();
   }
 }