From: Guido van Rossum <guido@python.org>
Date: Wed, 4 Apr 2007 17:43:02 +0000 (+0000)
Subject: Fix a race condition in this test -- instead of assuming that it will take
X-Git-Tag: v2.6a1~1873
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b1bb01e2f6a74814d347c295c625b6455c253857;p=python

Fix a race condition in this test -- instead of assuming that it will take
the test server thread at most 0.5 seconds to get ready, use an event
variable.
---

diff --git a/Lib/test/test_socketserver.py b/Lib/test/test_socketserver.py
index 9a67a358b7..bfcdf98a5c 100644
--- a/Lib/test/test_socketserver.py
+++ b/Lib/test/test_socketserver.py
@@ -74,6 +74,7 @@ class ServerThread(threading.Thread):
         self.__addr = addr
         self.__svrcls = svrcls
         self.__hdlrcls = hdlrcls
+        self.ready = threading.Event()
     def run(self):
         class svrcls(MyMixinServer, self.__svrcls):
             pass
@@ -87,6 +88,7 @@ class ServerThread(threading.Thread):
             if self.__addr != svr.socket.getsockname():
                 raise RuntimeError('server_address was %s, expected %s' %
                                        (self.__addr, svr.socket.getsockname()))
+        self.ready.set()
         if verbose: print "thread: serving three times"
         svr.serve_a_few()
         if verbose: print "thread: done"
@@ -139,7 +141,9 @@ def testloop(proto, servers, hdlrcls, testfunc):
         t.start()
         if verbose: print "server running"
         for i in range(NREQ):
-            time.sleep(DELAY)
+            t.ready.wait(10*DELAY)
+            if not t.ready.isSet():
+                raise RuntimeError("Server not ready within a reasonable time")
             if verbose: print "test client", i
             testfunc(proto, addr)
         if verbose: print "waiting for server"