From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Wed, 4 Jan 2023 04:09:36 +0000 (-0800)
Subject: expr scan: cast 'integer' field when accessing file handles
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b1b9ad69ac36cb05b655ad373e893faf6de05bdc;p=graphviz

expr scan: cast 'integer' field when accessing file handles

Squashes 2 -Wsign-conversion warnings. These values are known to be in range
here.
---

diff --git a/lib/expr/exeval.c b/lib/expr/exeval.c
index 4ae981bf0..ce6e1cc5a 100644
--- a/lib/expr/exeval.c
+++ b/lib/expr/exeval.c
@@ -516,7 +516,7 @@ scan(Expr_t* ex, Exnode_t* expr, void* env, Sfio_t* sp)
 		}
 		else
 			v.integer = 0;
-		if (v.integer < 0 || v.integer >= elementsof(ex->file) || (!(sp = ex->file[v.integer]) && !(sp = ex->file[v.integer] = sfnew(NULL, NULL, SF_UNBOUND, v.integer, SF_READ|SF_WRITE))))
+		if (v.integer < 0 || (size_t)v.integer >= elementsof(ex->file) || (!(sp = ex->file[v.integer]) && !(sp = ex->file[v.integer] = sfnew(NULL, NULL, SF_UNBOUND, (int)v.integer, SF_READ|SF_WRITE))))
 		{
 			exerror("scanf: %" PRIdMAX ": invalid descriptor", (intmax_t)v.integer);
 			return 0;