From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Tue, 13 Apr 2021 02:19:30 +0000 (-0700)
Subject: remove CreateHyperlink
X-Git-Tag: 2.47.2~52^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b158c49c2456be7ed277f1a2baa10ee2f309da24;p=graphviz

remove CreateHyperlink

This function was adding no value over just calling the Hyperlink constructor
directly.
---

diff --git a/plugin/visio/VisioRender.cpp b/plugin/visio/VisioRender.cpp
index d21fef96f..453e751c1 100644
--- a/plugin/visio/VisioRender.cpp
+++ b/plugin/visio/VisioRender.cpp
@@ -216,9 +216,9 @@ namespace Visio
 		AddText(job, Text::CreateText(job, p, span));
 	}
 
-	void Render::AddAnchor(GVJ_t *job, char *url, char *tooltip, char *target, char *id)
+	void Render::AddAnchor(GVJ_t *job, char *url, char *tooltip, char *target, char*)
 	{
-		AddHyperlink(job, Hyperlink::CreateHyperlink(job, url, tooltip, target, id));
+		AddHyperlink(job, Hyperlink(url, tooltip, target));
 	}
 	
 	void Render::ClearGraphicsAndTexts()
diff --git a/plugin/visio/VisioText.cpp b/plugin/visio/VisioText.cpp
index e53d87588..f092ebd1e 100644
--- a/plugin/visio/VisioText.cpp
+++ b/plugin/visio/VisioText.cpp
@@ -134,11 +134,6 @@ namespace Visio
 		_run.Print(job, index);
 	}
 
-	Hyperlink Hyperlink::CreateHyperlink(GVJ_t*, char* url, char* tooltip, char* target, char*)
-	{
-		return Hyperlink(tooltip, url, target);
-	}
-
 	Hyperlink::Hyperlink(const char* description, const char* address,
 		const char* frame):
 		_description(description),
diff --git a/plugin/visio/VisioText.h b/plugin/visio/VisioText.h
index 12b38edec..79de2d193 100644
--- a/plugin/visio/VisioText.h
+++ b/plugin/visio/VisioText.h
@@ -97,8 +97,6 @@ namespace Visio
 	class Hyperlink
 	{
 	public:
-		static Hyperlink CreateHyperlink(GVJ_t* job, char* url, char* tooltip, char* target, char* id);
-		
 		Hyperlink(const char* description, const char* address, const char* frame);
 		
 		/* given the id, whether it is default, output the hyperlink */