From: Mehdi Amini Date: Wed, 24 Aug 2016 04:26:57 +0000 (+0000) Subject: Remove excessive padding from PTHStatData (NFC) X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b0bac26745e3adce09b421cd3bc3e1122a363e0f;p=clang Remove excessive padding from PTHStatData (NFC) This diff reorders the fields and removes excessive padding. This fixes the following warning: PTHLexer.cpp:629:7: warning: Excessive padding in 'class (anonymous namespace)::PTHStatData' (14 padding bytes, where 6 is optimal). Optimal fields order: Size, ModTime, UniqueID, HasData, IsDirectory, consider reordering the fields or adding explicit padding members. Patch by: Alexander Shaposhnikov Differential Revision: https://reviews.llvm.org/D23826 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@279607 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Lex/PTHLexer.cpp b/lib/Lex/PTHLexer.cpp index dc678cf181..102aaf9133 100644 --- a/lib/Lex/PTHLexer.cpp +++ b/lib/Lex/PTHLexer.cpp @@ -628,15 +628,15 @@ PTHLexer *PTHManager::CreateLexer(FileID FID) { namespace { class PTHStatData { public: - const bool HasData; uint64_t Size; time_t ModTime; llvm::sys::fs::UniqueID UniqueID; + const bool HasData; bool IsDirectory; PTHStatData(uint64_t Size, time_t ModTime, llvm::sys::fs::UniqueID UniqueID, bool IsDirectory) - : HasData(true), Size(Size), ModTime(ModTime), UniqueID(UniqueID), + : Size(Size), ModTime(ModTime), UniqueID(UniqueID), HasData(true), IsDirectory(IsDirectory) {} PTHStatData() : HasData(false) {}