From: Mark Dickinson Date: Tue, 17 Mar 2009 18:01:03 +0000 (+0000) Subject: Fix bug in Decimal __format__ method that swapped left and right X-Git-Tag: v2.7a1~1848 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b065e52bc284c2c28a967c4e82aa7ece6d09c562;p=python Fix bug in Decimal __format__ method that swapped left and right alignment. --- diff --git a/Lib/decimal.py b/Lib/decimal.py index 1d12e87b13..2b16e6ab84 100644 --- a/Lib/decimal.py +++ b/Lib/decimal.py @@ -5551,9 +5551,9 @@ def _format_align(body, spec_dict): align = spec_dict['align'] if align == '<': - result = padding + sign + body - elif align == '>': result = sign + body + padding + elif align == '>': + result = padding + sign + body elif align == '=': result = sign + padding + body else: #align == '^' diff --git a/Lib/test/test_decimal.py b/Lib/test/test_decimal.py index 65aa033225..eed1eed081 100644 --- a/Lib/test/test_decimal.py +++ b/Lib/test/test_decimal.py @@ -704,6 +704,12 @@ class DecimalFormatTest(unittest.TestCase): ('.0g', '-sNaN', '-sNaN'), ('', '1.00', '1.00'), + + # check alignment + ('<6', '123', '123 '), + ('>6', '123', ' 123'), + ('^6', '123', ' 123 '), + ('=+6', '123', '+ 123'), ] for fmt, d, result in test_values: self.assertEqual(format(Decimal(d), fmt), result) diff --git a/Misc/NEWS b/Misc/NEWS index 9432295585..c506071b65 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -174,6 +174,9 @@ Core and Builtins Library ------- +- Fix Decimal.__format__ bug that swapped the meanings of the '<' and + '>' alignment characters. + - Issue #1222: locale.format() bug when the thousands separator is a space character.