From: Bram Moolenaar <Bram@vim.org>
Date: Thu, 30 Jun 2022 10:03:39 +0000 (+0100)
Subject: patch 9.0.0010: returning 0 for has('patch-9.0.0') is inconsistent
X-Git-Tag: v9.0.0010
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b0375d466e5ca57dca71995c342870b3226d8115;p=vim

patch 9.0.0010: returning 0 for has('patch-9.0.0') is inconsistent

Problem:    Returning 0 for has('patch-9.0.0') is inconsistent.
Solution:   Make it return 1. (closes #10640)
---

diff --git a/src/testdir/test_functions.vim b/src/testdir/test_functions.vim
index f55e846fa..38cd7930a 100644
--- a/src/testdir/test_functions.vim
+++ b/src/testdir/test_functions.vim
@@ -40,6 +40,9 @@ func Test_has()
   " Will we ever have patch 9999?
   let ver = 'patch-' .. v:version / 100 .. '.' .. v:version % 100 .. '.9999'
   call assert_equal(0, has(ver))
+
+  " There actually isn't a patch 9.0.0, but this is more consistent.
+  call assert_equal(1, has('patch-9.0.0'))
 endfunc
 
 func Test_empty()
diff --git a/src/version.c b/src/version.c
index 003984ab6..c2726aa77 100644
--- a/src/version.c
+++ b/src/version.c
@@ -735,6 +735,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    10,
 /**/
     9,
 /**/
@@ -789,11 +791,13 @@ has_patch(int n)
     // Perform a binary search.
     l = 0;
     h = (int)ARRAY_LENGTH(included_patches) - 1;
-    while (l < h)
+    for (;;)
     {
 	m = (l + h) / 2;
 	if (included_patches[m] == n)
 	    return TRUE;
+	if (l == h)
+	    break;
 	if (included_patches[m] < n)
 	    h = m;
 	else