From: Reid Kleckner Date: Wed, 13 Sep 2017 23:30:01 +0000 (+0000) Subject: [codeview] Fold FIXME into comment, there's nothing to do. NFC X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=b004b5074fccde7555bebd52fcd6644f7f9354c2;p=llvm [codeview] Fold FIXME into comment, there's nothing to do. NFC git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@313214 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp b/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp index 6eba00be00e..7e778c542c0 100644 --- a/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp +++ b/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp @@ -1277,10 +1277,10 @@ TypeIndex CodeViewDebug::lowerTypeArray(const DICompositeType *Ty) { "codeview doesn't support subranges with lower bounds"); int64_t Count = Subrange->getCount(); - // Variable length arrays and forward declarations of arrays without a size - // use a count of -1. Emit a count (and overall size) or zero in these cases - // to match what MSVC does for array declarations with no count. - // FIXME: Make front-end support VLA subrange and emit LF_DIMVARLU. + // Forward declarations of arrays without a size and VLAs use a count of -1. + // Emit a count of zero in these cases to match what MSVC does for arrays + // without a size. MSVC doesn't support VLAs, so it's not clear what we + // should do for them even if we could distinguish them. if (Count == -1) Count = 0;