From: Douglas Gregor Date: Fri, 13 Nov 2009 18:34:26 +0000 (+0000) Subject: When transforming an expression statement (e.g., for template X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=afe7ec28b1880335daba5f7310fe5191e14c4e76;p=clang When transforming an expression statement (e.g., for template instantiation), be sure to finish the expression statement by providing a FullExprArg, making sure that temporaries get destroyed. Fixes an obscure failure when parsing llvm/LinkAllPasses.h. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@88668 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Sema/SemaDeclCXX.cpp b/lib/Sema/SemaDeclCXX.cpp index 84934f5baf..be0163bbec 100644 --- a/lib/Sema/SemaDeclCXX.cpp +++ b/lib/Sema/SemaDeclCXX.cpp @@ -1348,7 +1348,7 @@ Sema::SetBaseOrMemberInitializers(CXXConstructorDecl *Constructor, if (const RecordType *FieldClassType = Field->getType()->getAs()) { CXXRecordDecl *FieldClassDecl - = cast(FieldClassType->getDecl()); + = cast(FieldClassType->getDecl()); for (RecordDecl::field_iterator FA = FieldClassDecl->field_begin(), EA = FieldClassDecl->field_end(); FA != EA; FA++) { if (CXXBaseOrMemberInitializer *Value = AllBaseFields.lookup(*FA)) { diff --git a/lib/Sema/TreeTransform.h b/lib/Sema/TreeTransform.h index 2095fba616..e46f9c75d2 100644 --- a/lib/Sema/TreeTransform.h +++ b/lib/Sema/TreeTransform.h @@ -1709,7 +1709,7 @@ Sema::OwningStmtResult TreeTransform::TransformStmt(Stmt *S) { if (E.isInvalid()) return getSema().StmtError(); - return getSema().Owned(E.takeAs()); + return getSema().ActOnExprStmt(getSema().FullExpr(E)); } }