From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 27 Feb 2008 17:44:51 +0000 (+0000)
Subject: If RelationBuildDesc() fails to open a critical system index, PANIC with
X-Git-Tag: REL8_0_16~30
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=afe57e993bea1c63527e8cde2971cb9d2fde9e75;p=postgresql

If RelationBuildDesc() fails to open a critical system index, PANIC with
a relevant error message instead of just dumping core.  Odd that nobody
reported this before Darren Reed.
---

diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index 7cd093d2fa..d1d3d8a901 100644
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.215.4.1 2006/01/19 20:28:57 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.215.4.2 2008/02/27 17:44:51 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -2404,6 +2404,9 @@ RelationCacheInitializePhase2(void)
 			buildinfo.infotype = INFO_RELNAME; \
 			buildinfo.i.info_name = (indname); \
 			ird = RelationBuildDesc(buildinfo, NULL); \
+			if (ird == NULL) \
+				elog(PANIC, "could not open critical system index \"%s\"", \
+					 indname); \
 			ird->rd_isnailed = true; \
 			ird->rd_refcnt = 1; \
 		} while (0)