From: Ilia Alshanetsky <iliaa@php.net>
Date: Sat, 24 Feb 2007 17:40:45 +0000 (+0000)
Subject: Eliminate strncpy and simplify code
X-Git-Tag: php-5.2.2RC1~285
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=afa4b732c51ed62b14d30c7dcb628046a61ea79a;p=php

Eliminate strncpy and simplify code
---

diff --git a/ext/exif/exif.c b/ext/exif/exif.c
index dcd52587a6..ff98ad7475 100644
--- a/ext/exif/exif.c
+++ b/ext/exif/exif.c
@@ -1002,13 +1002,10 @@ static char * exif_get_tagname(int tag_num, char *ret, int len, tag_table_type t
 				break;
 			}
 			if (ret && len)  {
-				strncpy(ret, tag_table[i].Desc, abs(len));
-				if (len<0) {
-					len = -len;
-					ret[len-1]='\0';
-					for(i=strlen(ret);i<len;i++)ret[i]=' ';
+				strlcpy(ret, tag_table[i].Desc, abs(len));
+				if (len < 0) {
+					memset(ret, ' ', -len - 1);
 				}
-				ret[len-1]='\0';
 				return ret;
 			}
 			return tag_table[i].Desc;
@@ -1016,13 +1013,10 @@ static char * exif_get_tagname(int tag_num, char *ret, int len, tag_table_type t
 	}
 	if (ret && len) {
 		snprintf(tmp, sizeof(tmp), "UndefinedTag:0x%04X", tag_num);
-		strncpy(ret, tmp, abs(len));
-		if (len<0) {
-			len = -len;
-			ret[len-1]='\0';
-			for(i=strlen(ret);i<len;i++)ret[i]=' ';
+		strlcpy(ret, tmp, abs(len));
+		if (len < 0) {
+			memset(ret, ' ', -len - 1);
 		}
-		ret[len-1]='\0';
 		return ret;
 	}
 	return "";