From: Benjamin Peterson <benjamin@python.org>
Date: Wed, 12 Mar 2014 23:05:53 +0000 (-0500)
Subject: use ssl.PROTOCOL_SSLv23 for maximum compatibility (closes #20896)
X-Git-Tag: v2.7.7rc1~134
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ae80f450a60a802de97d2eebee5d0be20f0c7ef5;p=python

use ssl.PROTOCOL_SSLv23 for maximum compatibility (closes #20896)
---

diff --git a/Lib/test/test_ssl.py b/Lib/test/test_ssl.py
index 426e261382..37a0cdb7c2 100644
--- a/Lib/test/test_ssl.py
+++ b/Lib/test/test_ssl.py
@@ -390,19 +390,24 @@ class NetworkedTests(unittest.TestCase):
 
     def test_get_server_certificate(self):
         with test_support.transient_internet("svn.python.org"):
-            pem = ssl.get_server_certificate(("svn.python.org", 443))
+            pem = ssl.get_server_certificate(("svn.python.org", 443),
+                                             ssl.PROTOCOL_SSLv23)
             if not pem:
                 self.fail("No server certificate on svn.python.org:443!")
 
             try:
-                pem = ssl.get_server_certificate(("svn.python.org", 443), ca_certs=CERTFILE)
+                pem = ssl.get_server_certificate(("svn.python.org", 443),
+                                                 ssl.PROTOCOL_SSLv23,
+                                                 ca_certs=CERTFILE)
             except ssl.SSLError:
                 #should fail
                 pass
             else:
                 self.fail("Got server certificate %s for svn.python.org!" % pem)
 
-            pem = ssl.get_server_certificate(("svn.python.org", 443), ca_certs=SVN_PYTHON_ORG_ROOT_CERT)
+            pem = ssl.get_server_certificate(("svn.python.org", 443),
+                                             ssl.PROTOCOL_SSLv23,
+                                             ca_certs=SVN_PYTHON_ORG_ROOT_CERT)
             if not pem:
                 self.fail("No server certificate on svn.python.org:443!")
             if test_support.verbose: