From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Mon, 11 Jan 2016 23:23:19 +0000 (-0700)
Subject: On overflow, warn before freeing anything.
X-Git-Tag: SUDO_1_8_16^2~74
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ae5a2f407272b634c75f7112479ab0babaa25c7b;p=sudo

On overflow, warn before freeing anything.
---

diff --git a/plugins/sudoers/ldap.c b/plugins/sudoers/ldap.c
index be074ca90..b1c2000ff 100644
--- a/plugins/sudoers/ldap.c
+++ b/plugins/sudoers/ldap.c
@@ -1361,8 +1361,8 @@ oom:
 	ldap_msgfree(result);
     debug_return_bool(false);
 overflow:
-    free(filt);
     sudo_warnx(U_("internal error, %s overflow"), __func__);
+    free(filt);
     debug_return_bool(false);
 }
 
@@ -1533,8 +1533,8 @@ oom:
     ldap_msgfree(result);
     debug_return_bool(false);
 overflow:
-    free(filt);
     sudo_warnx(U_("internal error, %s overflow"), __func__);
+    free(filt);
     debug_return_bool(false);
 }
 
@@ -1689,8 +1689,8 @@ sudo_ldap_build_pass1(LDAP *ld, struct passwd *pw)
 
     debug_return_str(buf);
 overflow:
-    free(buf);
     sudo_warnx(U_("internal error, %s overflow"), __func__);
+    free(buf);
     debug_return_str(NULL);
 }