From: Simon Pilgrim <llvm-dev@redking.me.uk>
Date: Thu, 3 Oct 2019 21:27:02 +0000 (+0000)
Subject: OverloadCandidate::getNumParams - silence static analyzer getAs<FunctionProtoType... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ae56b6c181f93a82e8e8ed960f9a88f6e0817e0d;p=clang

OverloadCandidate::getNumParams - silence static analyzer getAs<FunctionProtoType> null dereference warning. NFCI.

The static analyzer is warning about a potential null dereference, but we should be able to use castAs<FunctionProtoType> directly and if not assert will fire for us.

Also replaces an auto to make the type more obvious.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@373665 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/include/clang/Sema/Overload.h b/include/clang/Sema/Overload.h
index e9280103a3..144e6d927c 100644
--- a/include/clang/Sema/Overload.h
+++ b/include/clang/Sema/Overload.h
@@ -826,10 +826,10 @@ class Sema;
 
     unsigned getNumParams() const {
       if (IsSurrogate) {
-        auto STy = Surrogate->getConversionType();
+        QualType STy = Surrogate->getConversionType();
         while (STy->isPointerType() || STy->isReferenceType())
           STy = STy->getPointeeType();
-        return STy->getAs<FunctionProtoType>()->getNumParams();
+        return STy->castAs<FunctionProtoType>()->getNumParams();
       }
       if (Function)
         return Function->getNumParams();