From: foobar <sniper@php.net>
Date: Tue, 23 Apr 2002 00:14:08 +0000 (+0000)
Subject: Changed the error for 'no upload' to E_NOTICE so that it doesn't
X-Git-Tag: php-4.3.0dev-ZendEngine2-Preview1~492
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ae2e36a4e5a74fbcd3f58d2ea3b9371a3cf0410e;p=php

Changed the error for 'no upload' to E_NOTICE so that it doesn't
pollute the logs too much.

@- Fixed possible crash bug in HTTP uploads. (Patch: Lucas Schroeder)
---

diff --git a/main/rfc1867.c b/main/rfc1867.c
index 5c997cda6a..84c6078e38 100644
--- a/main/rfc1867.c
+++ b/main/rfc1867.c
@@ -371,11 +371,12 @@ static char *php_mime_get_hdr_value(zend_llist header, char *key)
 	}
 	
 	entry = zend_llist_get_first(&header);
-	do {
+	while (entry) {
 		if (!strcasecmp(entry->key, key)) {
 			return entry->value;
 		}
-	} while ((entry = zend_llist_get_next(&header)));
+		entry = zend_llist_get_next(&header);
+	}
 	
 	return NULL;
 }
@@ -726,7 +727,7 @@ SAPI_API SAPI_POST_HANDLER_FUNC(rfc1867_post_handler)
 			cancel_upload = 0;
 
 			if(strlen(filename) == 0) {
-				sapi_module.sapi_error(E_WARNING, "No file uploaded");
+				sapi_module.sapi_error(E_NOTICE, "No file uploaded");
 				cancel_upload = UPLOAD_ERROR_D;
 			}