From: Ilia Alshanetsky <iliaa@php.net>
Date: Fri, 30 Jan 2009 00:17:05 +0000 (+0000)
Subject: MFB: Improved validation checks inside str_pad()
X-Git-Tag: php-5.2.9RC1~20
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=adfdb7a77fed92567b09664b0220679ea9bd8ec3;p=php

MFB: Improved validation checks inside str_pad()
---

diff --git a/ext/standard/string.c b/ext/standard/string.c
index d7c3164f8d..e1062afac3 100644
--- a/ext/standard/string.c
+++ b/ext/standard/string.c
@@ -4922,7 +4922,7 @@ PHP_FUNCTION(str_pad)
 
 	/* If resulting string turns out to be shorter than input string,
 	   we simply copy the input and return. */
-	if (Z_LVAL_PP(pad_length) < 0 || num_pad_chars < 0) {
+	if (Z_LVAL_PP(pad_length) <= 0 || num_pad_chars <= 0) {
 		RETURN_ZVAL(*input, 1, 0);
 	}