From: Gregory P. Smith <greg@krypto.org>
Date: Sat, 2 Feb 2013 01:05:29 +0000 (-0800)
Subject: In the _hashlib module, only initialize the static data for OpenSSL's
X-Git-Tag: v3.3.1rc1~253^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=aded2e5e59a122962ccbf8058cd306da344f27b9;p=python

In the _hashlib module, only initialize the static data for OpenSSL's
constructors once, to avoid memory leaks when finalizing and re-initializing
the Python interpreter.
---

diff --git a/Modules/_hashopenssl.c b/Modules/_hashopenssl.c
index dd4317fca0..8bcf71d66a 100644
--- a/Modules/_hashopenssl.c
+++ b/Modules/_hashopenssl.c
@@ -70,7 +70,7 @@ static PyTypeObject EVPtype;
 
 
 #define DEFINE_CONSTS_FOR_NEW(Name)  \
-    static PyObject *CONST_ ## Name ## _name_obj; \
+    static PyObject *CONST_ ## Name ## _name_obj = NULL; \
     static EVP_MD_CTX CONST_new_ ## Name ## _ctx; \
     static EVP_MD_CTX *CONST_new_ ## Name ## _ctx_p = NULL;
 
@@ -587,12 +587,15 @@ generate_hash_name_list(void)
                   " hash object; optionally initialized with a string") \
     }
 
-/* used in the init function to setup a constructor */
+/* used in the init function to setup a constructor: initialize OpenSSL
+   constructor constants if they haven't been initialized already.  */
 #define INIT_CONSTRUCTOR_CONSTANTS(NAME)  do { \
-    CONST_ ## NAME ## _name_obj = PyUnicode_FromString(#NAME); \
-    if (EVP_get_digestbyname(#NAME)) { \
-        CONST_new_ ## NAME ## _ctx_p = &CONST_new_ ## NAME ## _ctx; \
-        EVP_DigestInit(CONST_new_ ## NAME ## _ctx_p, EVP_get_digestbyname(#NAME)); \
+    if (CONST_ ## NAME ## _name_obj == NULL) { \
+        CONST_ ## NAME ## _name_obj = PyUnicode_FromString(#NAME); \
+        if (EVP_get_digestbyname(#NAME)) { \
+            CONST_new_ ## NAME ## _ctx_p = &CONST_new_ ## NAME ## _ctx; \
+            EVP_DigestInit(CONST_new_ ## NAME ## _ctx_p, EVP_get_digestbyname(#NAME)); \
+        } \
     } \
 } while (0);